Make .sleep(..) return a coroutine#18772
Merged
erikjohnston merged 4 commits intodevelopfrom Aug 5, 2025
Merged
Conversation
This helps ensure that mypy can catch places where we don't await on it, like in #18763.
3 tasks
MadLittleMods
approved these changes
Aug 4, 2025
|
|
||
| @defer.inlineCallbacks | ||
| def sleep(self, seconds: float) -> "Generator[Deferred[float], Any, Any]": | ||
| async def sleep(self, seconds: float) -> None: |
Contributor
There was a problem hiding this comment.
It looks like this other spot doesn't have types and is in contrib/ so we don't necessarily need to change it but we could also align
synapse/contrib/cmdclient/http.py
Lines 178 to 181 in 7ed5566
Member
Author
There was a problem hiding this comment.
Oh, mmm good spot. Looking at it though I'm disinclined to try and move it to async/await as it still users generators and @defer.inlineCallbacks everywhere else. If anything I'd be inclined to remove the cmdclient package entirely
Co-authored-by: Eric Eastwood <erice@element.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This helps ensure that mypy can catch places where we don't await on it, like in #18763.